Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Ubuntu 18.04 compatibility #230

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

luke-c-sargent
Copy link
Member

This PR addresses a few issues with using this component of the GalaxyKickstart stack:

  1. using ppa:natefoo/slurm-drmaa to get slurm components
  2. slurm-wlm in lieu of slurm-llnl when using Ubuntu 18.04
  3. fix in templates/configure_slurm.py.j2 to deal with some cruft left in the 'split' mechanism of status parsing

this has been tested on Ubuntu 18.04; i was able to install some tools from the shed and run Galaxy 101 to completion. When using it as part of GalaxyKickstart, I successfully installed to Ubuntu 16.04 and 18.04, though it required some modifications to galaxy-os which i plan to issue a PR to should this approach be deemed acceptable.

critiques welcome!

@drosofff drosofff self-requested a review March 26, 2019 22:29
@drosofff
Copy link
Member

Hi @luke-c-sargent. What are the modification planned in ansible-galaxy-os ?

@drosofff
Copy link
Member

drosofff commented Mar 26, 2019

I see @luke-c-sargent !

No package matching 'slurm-drmaa-dev'

It works effortlessly in ubuntu 16.04, so at least this part of deployment in galaxykickstart is preserved ;-)
For the rest, I guess it will be ok with the change in galaxy-os

@luke-c-sargent
Copy link
Member Author

@drosofff
the mentioned galaxy-os PR:
galaxyproject/ansible-galaxy-os#29

it's the same repo addition, since that role also installs slurm-drmaa-dev; i assume the redundancy is for flexibility, in case you want to use either one role or the other, but not both (irrelevant for GKS).

Side note: 14.04 installations no longer work; this is probably for the best since its end of life is next month, but many of the ansible-galaxy-* roles mention it as the preferred Ubuntu version, which should probably be changed.

@abretaud
Copy link
Contributor

Could you rebase/fix the conflicts? There's been some change on the master including things overlapping with this PR + the tests are now run with ubuntu 18.04

Base automatically changed from master to main March 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants