-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Ubuntu 18.04 compatibility #230
base: main
Are you sure you want to change the base?
Conversation
Hi @luke-c-sargent. What are the modification planned in ansible-galaxy-os ? |
I see @luke-c-sargent !
It works effortlessly in ubuntu 16.04, so at least this part of deployment in galaxykickstart is preserved ;-) |
@drosofff it's the same repo addition, since that role also installs slurm-drmaa-dev; i assume the redundancy is for flexibility, in case you want to use either one role or the other, but not both (irrelevant for GKS). Side note: 14.04 installations no longer work; this is probably for the best since its end of life is next month, but many of the ansible-galaxy-* roles mention it as the preferred Ubuntu version, which should probably be changed. |
Could you rebase/fix the conflicts? There's been some change on the master including things overlapping with this PR + the tests are now run with ubuntu 18.04 |
This PR addresses a few issues with using this component of the GalaxyKickstart stack:
ppa:natefoo/slurm-drmaa
to get slurm componentstemplates/configure_slurm.py.j2
to deal with some cruft left in the 'split' mechanism of status parsingthis has been tested on Ubuntu 18.04; i was able to install some tools from the shed and run Galaxy 101 to completion. When using it as part of GalaxyKickstart, I successfully installed to Ubuntu 16.04 and 18.04, though it required some modifications to galaxy-os which i plan to issue a PR to should this approach be deemed acceptable.
critiques welcome!