Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce envsubst as a new way to change variables during startup #144

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bgruening
Copy link
Member

Some docs are included I would like to know if this is ok for this project as it makes things certainly more complicated. @erasche @mvdbeek @jmchilton

@abretaud what do you think about this. It whould make proxy_prefix fully working, I think.

@abretaud
Copy link
Contributor

I can't test right now, but it looks great! 👍

@mvdbeek
Copy link
Member

mvdbeek commented May 16, 2017

I don't see why we're not using ansible, but if it's restricted to startup.sh.j2 it's fine.
For the nginx proxy prefix in the Docker variant of GalaxyKickStart we simply run the nginx tagged tasks on startup (See https://github.com/ARTbio/GalaxyKickStart/blob/master/startup.sh). Admittedly you'll need to have ansible installed, so if that's the reason I'd say why not.

@mvdbeek
Copy link
Member

mvdbeek commented May 21, 2017

Btw, we could add this https://github.com/arut/nginx-python-module to our nginx PPA, that should allow us to pull in env vars.

@bgruening
Copy link
Member Author

@mvdbeek thanks for looking into this. I'm not sure either if this is a good idea, but it is very light-weight and I don't need to carry around ansible, which is pretty heavy if you consider the entire python runtime env and additional libraries. The proposed concept was not for nginx alone and can be used by a lot more if people need to.

Base automatically changed from master to main March 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants