fix: refraining from using gopool for long-running tasks (bnb-chain#20)

Co-authored-by: Welkin <welkin.b@nodereal.com>
galaio · Jan 5, 2024 · e13d451 · e13d451
1 parent 9d35ab5
commit e13d451
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/eth/bloombits.go b/eth/bloombits.go
@@ -20,7 +20,6 @@ import (
 	"time"
 
 	"github.com/ethereum/go-ethereum/common/bitutil"
-	"github.com/ethereum/go-ethereum/common/gopool"
 	"github.com/ethereum/go-ethereum/core/rawdb"
 )
 
@@ -46,7 +45,7 @@ const (
 // retrievals from possibly a range of filters and serving the data to satisfy.
 func (eth *Ethereum) startBloomHandlers(sectionSize uint64) {
 	for i := 0; i < bloomServiceThreads; i++ {
-		gopool.Submit(func() {
+		go func() {
 			for {
 				select {
 				case <-eth.closeBloomHandler:
@@ -70,6 +69,6 @@ func (eth *Ethereum) startBloomHandlers(sectionSize uint64) {
 					request <- task
 				}
 			}
-		})
+		}()
 	}
 }
diff --git a/p2p/dial.go b/p2p/dial.go
@@ -178,8 +178,8 @@ func newDialScheduler(config dialConfig, it enode.Iterator, setupFunc dialSetupF
 	d.lastStatsLog = d.clock.Now()
 	d.ctx, d.cancel = context.WithCancel(context.Background())
 	d.wg.Add(2)
-	gopool.Submit(func() { d.readNodes(it) })
-	gopool.Submit(func() { d.loop(it) })
+	go func() { d.readNodes(it) }()
+	go func() { d.loop(it) }()
 	return d
 }