Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBR shader support Iridescence #2425
PBR shader support Iridescence #2425
Changes from 42 commits
5a26f3d
5ecc318
cafc24f
dc69489
221b7b6
0d45d9c
0f14c3f
8871d9b
3b4ffd7
f649a58
598fc56
e33a66f
41ef06f
b5214fc
f36ce02
ff8b7c2
634236f
91e6fa4
3932448
671cace
92b972e
9226d38
ff6a69a
0838968
82d5a8f
39043a2
ad61eed
2b308ec
2c1604f
0be9f2a
88f89f2
b5b9a0a
d7a82de
d1547d4
76c5423
aa41aaf
f4b16fd
9fb543f
647b8a9
e70ee42
8f41f62
499bd70
e644dff
6f418fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 146 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L145-L146
Check warning on line 159 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L149-L159
Check warning on line 166 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L165-L166
Check warning on line 176 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L169-L176
Check warning on line 184 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L183-L184
Check warning on line 189 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L187-L189
Check warning on line 197 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L196-L197
Check warning on line 203 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L200-L203
Check warning on line 213 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L212-L213
Check warning on line 223 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L216-L223
Check warning on line 245 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L243-L245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation for iridescenceIor
The IOR (Index of Refraction) value should be validated as it typically should be greater than 1.0 for physical accuracy.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Validate thickness range values
The thickness range values should be validated to ensure minimum is less than maximum and both are positive.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve texture loading implementation
The current texture loading implementation has several issues:
Consider implementing this pattern:
Apply similar changes to the iridescenceThicknessTexture loading block.
Also applies to: 34-37
Check warning on line 39 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts
packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts#L11-L39