Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of animation playback for multiple same type components under an Entity #2095

Merged
merged 3 commits into from
May 13, 2024

Conversation

luzhuang
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added the bug Something isn't working label May 13, 2024
@luzhuang luzhuang requested a review from GuoLei1990 May 13, 2024 03:44
@GuoLei1990 GuoLei1990 changed the title fix: multi subMesh animation bug Fix multi subMesh animation bug May 13, 2024
@luzhuang luzhuang changed the title Fix multi subMesh animation bug Fix the bug of animation playback for multiple identical components under an Entity May 13, 2024
@GuoLei1990 GuoLei1990 changed the title Fix the bug of animation playback for multiple identical components under an Entity Fix the bug of animation playback for multiple same components under an Entity May 13, 2024
@GuoLei1990 GuoLei1990 changed the title Fix the bug of animation playback for multiple same components under an Entity Fix the bug of animation playback for multiple same type components under an Entity May 13, 2024
@GuoLei1990 GuoLei1990 merged commit 1bf6822 into galacean:main May 13, 2024
6 checks passed
@GuoLei1990 GuoLei1990 added the animation Built-in animation system related functions label May 13, 2024
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Jun 3, 2024
* dev/1.3:
  fix: use default material to prevent material[] (galacean#2104)
  Add `Script` in `onStart` may cause some functions to not be executed correctly. (galacean#2102)
  "v1.2.0-beta.5"
  Redesign `Skin` of `SkinnedMeshRenderer` (galacean#2100)
  Fix glTF renderer component's order is random now (galacean#2097)
  "v1.2.0-beta.4"
  "v1.2.0-beta.3"
  Fix the bug of animation playback for multiple same type components under an Entity (galacean#2095)
  Support get any subAsset from GLTFParser (galacean#2093)
  Replace `throw` with `console.error` to prevent blocking the main thread (galacean#2077)
  Fixed the problem that function macro declaration is lost after compilation (galacean#2087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants