Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix particle error when restore context #2068

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Fix particle error when restore context #2068

merged 1 commit into from
Apr 7, 2024

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Apr 7, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Occurs frequently in unit test CI:
image

@GuoLei1990 GuoLei1990 added test unit test resource Resource-related functions particle bug Something isn't working and removed test unit test labels Apr 7, 2024
@GuoLei1990 GuoLei1990 requested review from jtabibito and JujieX April 7, 2024 09:40
jtabibito
jtabibito approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@jtabibito jtabibito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit ee8dbab into galacean:main Apr 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtabibito jtabibito jtabibito approved these changes

@JujieX JujieX JujieX approved these changes

Assignees
No one assigned
Labels
bug Something isn't working particle resource Resource-related functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuoLei1990 @jtabibito @JujieX