Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add particle shape for wireframeManager #253

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Feat: add particle shape for wireframeManager #253

merged 2 commits into from
Jan 18, 2024

Conversation

JujieX
Copy link
Member

@JujieX JujieX commented Jan 16, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

WireframeManager could draw particleRenderer's emission shape

@JujieX JujieX added the feature New feature label Jan 16, 2024
@JujieX JujieX added this to the 1.2 milestone Jan 16, 2024
cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JujieX JujieX self-assigned this Jan 18, 2024
@JujieX JujieX merged commit b53fb0f into galacean:dev/1.2 Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

Assignees

@JujieX JujieX

Labels
feature New feature
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JujieX @cptbtptpbcptdtptp