Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onLateUpdate for drawing wireframe #239

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix onLateUpdate for drawing wireframe #239

merged 1 commit into from
Dec 12, 2023

Conversation

JujieX
Copy link
Member

@JujieX JujieX commented Dec 12, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

by using onLateUpdate for drawing wireframe to avoid conflict of .clear() and .draw() order

@JujieX JujieX added the bug Something isn't working label Dec 12, 2023
@JujieX JujieX self-assigned this Dec 12, 2023
singlecoder
singlecoder approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JujieX JujieX changed the title Fix: onLateUpdate for drawing wireframe Fix onLateUpdate for drawing wireframe Dec 12, 2023
@JujieX JujieX merged commit b1c97af into galacean:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singlecoder singlecoder singlecoder approved these changes

Assignees

@JujieX JujieX

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JujieX @singlecoder