Skip to content

fix: prevent video from auto-playing when it finishes loading #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiiqii merged 3 commits into from
Dec 15, 2025
Merged

fix: prevent video from auto-playing when it finishes loading #1316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee5103e
fix: video autoplay on load
ChengYi996 Dec 12, 2025
d43e69f
chore: ensure video has enough buffer before play
ChengYi996 Dec 12, 2025
0d996c2
fix: memory leak
ChengYi996 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/effects-core/src/downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,21 +284,20 @@ export async function loadVideo (url: string | MediaProvider): Promise<HTMLVideo
video.setAttribute('playsinline', 'playsinline');

return new Promise<HTMLVideoElement>((resolve, reject) => {
const pending = video.play().catch(e => {
reject(e);
});

if (pending) {
void pending.then(() => resolve(video));
} else {
video.addEventListener('loadeddata', function listener () {
resolve(video);
video.removeEventListener('loadeddata', listener);
}, true);
}
video.addEventListener('error', e => {
const handleCanPlay = () => {
resolve(video);
video.removeEventListener('error', handleError);
};
const handleError = (e: any) => {
video.removeEventListener('canplay', handleCanPlay);
reject('Load video fail.');
});
};

video.addEventListener('canplay', handleCanPlay, { once: true });
video.addEventListener('error', handleError, { once: true });

// 显式触发视频加载
video.load();
});
}

Expand Down