Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(abigen): safe ident field names #989

Merged
merged 1 commit into from
Mar 5, 2022
Merged

fix(abigen): safe ident field names #989

merged 1 commit into from
Mar 5, 2022

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Mar 5, 2022 •
edited
Loading

Motivation

I was generating bindings for a contract that imports dYdX's I_Solo.sol and got an error because AssetAmount has a field that is called ref.

Solution

ref is a reserved word, so I use util::safe_ident instead of util::ident for field names.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit 46d7afd into gakonst:master Mar 5, 2022
@clifton clifton mentioned this pull request Jul 21, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oblique @gakonst