Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Refactor: organize ethers-providers #2159

Merged
merged 18 commits into from
Feb 20, 2023
Merged

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Feb 17, 2023

Depends on #2122

Cleans up the ethers-providers crate by organizing modules into a more clean layout.

TODONES:

  • update docs for existing modules
  • ensure all modules are documented

@gakonst
Copy link
Owner

gakonst commented Feb 17, 2023

concept ack, let's merge once the base is merged

@prestwich prestwich force-pushed the prestwich/provider-layout-refactor branch 3 times, most recently from e56a8af to bfb894d Compare February 17, 2023 17:07
@gakonst
Copy link
Owner

gakonst commented Feb 20, 2023

needs rebase since we merged your middleware errors PR. lgtm otherwise and supportive

@prestwich prestwich force-pushed the prestwich/provider-layout-refactor branch from bfb894d to 84aca0d Compare February 20, 2023 04:32
@prestwich
Copy link
Collaborator Author

rebased and gitpilled

@prestwich prestwich marked this pull request as ready for review February 20, 2023 17:43
@prestwich
Copy link
Collaborator Author

docs suck less now, this should be ready to go :)

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very based. Nits

ethers-contract/tests/it/contract.rs Outdated Show resolved Hide resolved
ethers-providers/src/stream/watcher.rs Outdated Show resolved Hide resolved
examples/providers/examples/custom.rs Show resolved Hide resolved
@gakonst gakonst merged commit ef6e7f4 into master Feb 20, 2023
@gakonst gakonst deleted the prestwich/provider-layout-refactor branch February 20, 2023 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants