This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(signers): Allow parsing of private key that has 0x prefix
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Jan 10, 2023
| @@ -191,7 +192,7 @@ pub enum Authorization { | |||
|
|
|||
| impl Authorization { | |||
| pub fn basic(username: impl Into<String>, password: impl Into<String>) -> Self { | |||
| let auth_secret = base64::encode(username.into() + ":" + &password.into()); | |||
| let auth_secret = BASE64_STANDARD.encode(username.into() + ":" + &password.into()); | |||
There was a problem hiding this comment.
this looks like a separate change that bumps base64
mind submitting this separately?
Comment on lines
+140
to
+154
| impl TryFrom<&str> for Wallet<SigningKey> { | ||
| type Error = WalletError; | ||
|
|
||
| fn try_from(value: &str) -> Result<Self, Self::Error> { | ||
| value.parse() | ||
| } | ||
| } | ||
|
|
||
| impl TryFrom<String> for Wallet<SigningKey> { | ||
| type Error = WalletError; | ||
|
|
||
| fn try_from(value: String) -> Result<Self, Self::Error> { | ||
| value.parse() | ||
| } | ||
| } |
There was a problem hiding this comment.
there's no transient impl when there's FromStr?
I guess we can add these
There was a problem hiding this comment.
The reason I added this is to enable user to have something like this:
fn create_client(url: &str, priv_key: impl TryInto<LocalWallet>) -> SignerMiddleware<Provider<Http>, LocalWallet>> {
let wallet = priv_key.try_into().unwrap();
// ...
}And be able to pass as argument &str, String, SigningKey, and SecretKey<Secp256k1>.
mattsse
approved these changes
Jan 11, 2023
gakonst
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I wanted to be able to use private keys that have
0xprefix, without stripping it manually.Solution
Remove prefix in
Wallet<SigningKey>::from_str.PR Checklist