Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Add Arithmetic Shift Right operation for I256 #1323

Closed
dbelv opened this issue May 29, 2022 · 2 comments
Closed

Add Arithmetic Shift Right operation for I256 #1323

dbelv opened this issue May 29, 2022 · 2 comments

Comments

@dbelv
Copy link
Contributor

dbelv commented May 29, 2022

Is your feature request related to a problem? Please describe.
Add Arithmetic Shift Right operation for I256

Describe the solution you'd like
Add Arithmetic Shift Right operation for I256.

Describe alternatives you've considered
The user can perform this operation themselves.

dbelv added a commit to dbelv/ethers-rs that referenced this issue May 29, 2022
@dbelv
Copy link
Contributor Author

dbelv commented May 29, 2022

The base rust types perform asr when the value is negative for the Shr trait, however as lsr has been the default for the Shr trait for I256 this has been implemented as a separate function. This can be implemented within the Shr trait breaking backwards compatibility if preferred.

PR for separate asr function: #1324

dbelv added a commit to dbelv/ethers-rs that referenced this issue May 29, 2022
Update the changelog for gakonst#1323

Format the file correctly
gakonst pushed a commit that referenced this issue May 29, 2022
Update the changelog for #1323

Format the file correctly
@gakonst
Copy link
Owner

gakonst commented Jun 1, 2022

Closed in #1324

@gakonst gakonst closed this as completed Jun 1, 2022
jsLover1117 added a commit to jsLover1117/ethers-rs that referenced this issue Jul 17, 2022
Update the changelog for gakonst/ethers-rs#1323

Format the file correctly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants