-
-
Notifications
You must be signed in to change notification settings - Fork 83
Immutable v4 compatibility #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good. Is is ready to be merged? |
If you agree that |
👍 go for it, this PR is fine. |
Good to go 😄 |
Thank you |
Thank you for such a useful module. |
@gajus Thanks for the package! We upgraded to Immutable v4 and noticed that this change, while merged, isn't published to NPM yet. Is it possible to publish it? |
Nevermind my comment. It is indeed already published as v4. |
Would people consider bumping this to "peerDependencies": {
"immutable": "^3.8.1 || ^4.0.0-rc.9"
},
"devDependencies": {
"immutable": "^3.8.1 || ^4.0.0-rc.9"
} |
Closes #46
Also I would like to propose separating
immutable
dependency intopeerDependencies
anddevDependencies
:That way if a user's project at large uses
immutable@^4
, redux-immutable won't try to pull inimmutable@3.8.1
as a local dependency, but rather import from the project. Avoids bloating up bundle size.Conditional
devDependencies
avoids npm warnings when switching betweenimmutable
versions in development.3.8.1
is installed by default.