Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check peerDependencies in imports-as-dependencies #1113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DetachHead
Copy link

No description provided.

@brettz9
Copy link
Collaborator

brettz9 commented Jun 5, 2023

Hmmm, maybe this should be optional?... It would seem to me some projects (like eslint-plugin-jsdoc itself) want to ensure the imports are in devDependencies and not just in peerDependencies, no?

@DetachHead
Copy link
Author

maybe all three of them should be optional like in import/no-extraneous-dependencies?

@brettz9
Copy link
Collaborator

brettz9 commented Jun 9, 2023

That would be fine, though I think default off for peer and default on for the others...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants