require-returns: More AST types

Author: brettz9

src/jsdocUtils.js

@@ -662,27 +662,41 @@ const hasNonEmptyResolverCall = (node, resolverName) => {
     });
   }
 
-  /*
-  case 'ArrayExpression': case 'AssignmentPattern':
+  case 'ArrayExpression':
+    return node.elements.some((bodyNode) => {
+      return hasNonEmptyResolverCall(bodyNode, resolverName);
+    });
+
   case 'AwaitExpression':
-  case 'MemberExpression': case 'OptionalMemberExpression':
+  case 'SpreadElement':
+  case 'UnaryExpression':
+  case 'YieldExpression':
+    return hasNonEmptyResolverCall(node.argument, resolverName);
+
+  /*
+  case 'LabeledStatement':
   case 'VariableDeclaration':
-  case 'OptionalCallExpression':
+
+  case 'MemberExpression': case 'OptionalMemberExpression': // ?.
+  case 'OptionalCallExpression': ?.x()
+
   case 'TaggedTemplateExpression':
-  case 'TemplateElement': case 'TemplateLiteral': case 'UnaryExpression':
-  case 'SpreadElement':
+  case 'TemplateElement': case 'TemplateLiteral':
+
+  case 'AssignmentPattern':
   case 'ArrayPattern': case 'ObjectPattern':
+
   case 'ObjectExpression':
   case 'Property':
+
   case 'ClassProperty':
   case 'ClassDeclaration': case 'ClassExpression': case 'MethodDefinition':
   case 'Super':
+
   case 'ExportDefaultDeclaration': case 'ExportNamedDeclaration':
-  case 'LabeledStatement':
   case 'Import':
   case 'ImportExpression':
   case 'Decorator':
-  case 'YieldExpression':
 
     // Todo: Add these (and also add to Yield/Throw checks)
     return false;

test/rules/assertions/requireReturns.js

@@ -1040,6 +1040,68 @@ export default {
       ],
       ignoreReadme: true,
     },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              +resolve();
+              [...resolve()];
+              [resolve(true)];
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise(function * (resolve, reject) {
+              yield resolve(true)
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise(async function (resolve, reject) {
+              await resolve(true)
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+      parserOptions: {
+        ecmaVersion: 8,
+      },
+    },
     {
       code: `
           /**