Skip to content

Commit 7362525

Browse files
committed
refactor: minimize lodash dependency
1 parent b2bf54d commit 7362525

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/rules/noUndefinedTypes.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ export default iterateJsdoc(({
3939
let definedPreferredTypes = [];
4040
const {preferredTypes, mode} = settings;
4141
if (Object.keys(preferredTypes).length) {
42-
// Replace `_.values` with `Object.values` when we may start requiring Node 7+
43-
definedPreferredTypes = _.values(preferredTypes).map((preferredType) => {
42+
definedPreferredTypes = Object.values(preferredTypes).map((preferredType) => {
4443
if (typeof preferredType === 'string') {
4544
// May become an empty string but will be filtered out below
4645
return stripPseudoTypes(preferredType);
@@ -157,7 +156,7 @@ export default iterateJsdoc(({
157156
if (type === 'NAME') {
158157
if (!allDefinedTypes.has(name)) {
159158
report(`The type '${name}' is undefined.`, null, tag);
160-
} else if (!_.includes(extraTypes, name)) {
159+
} else if (!extraTypes.includes(name)) {
161160
context.markVariableAsUsed(name);
162161
}
163162
}

src/rules/requireDescriptionCompleteSentence.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ const validateDescription = (
8585
let text = sourceCode.getText(jsdocNode);
8686

8787
if (!/[.:?!]$/u.test(paragraph)) {
88-
const line = _.last(paragraph.split('\n'));
88+
const line = paragraph.split('\n').pop();
8989

9090
text = text.replace(new RegExp(`${_.escapeRegExp(line)}$`, 'mu'), `${line}.`);
9191
}

0 commit comments

Comments
 (0)