require-returns: for resolves, check more node types

Also ignores coverage-focused test for README

Author: brettz9

README.md

@@ -14919,19 +14919,6 @@ function quux () {
 }
 // Message: Missing JSDoc @returns declaration.
 
-/**
- *
- */
-function quux () {
-  return new Promise((resolve, reject) => {
-    return () => {
-      identifierForCoverage;
-      resolve(true);
-    };
-  });
-}
-// Message: Missing JSDoc @returns declaration.
-
 /**
  *
  */

src/jsdocUtils.js

@@ -627,8 +627,10 @@ const hasNonEmptyResolverCall = (node, resolverName) => {
   case 'WithStatement': {
     return hasNonEmptyResolverCall(node.body, resolverName);
   }
+  case 'ConditionalExpression':
   case 'IfStatement': {
-    return hasNonEmptyResolverCall(node.consequent, resolverName) ||
+    return hasNonEmptyResolverCall(node.test, resolverName) ||
+      hasNonEmptyResolverCall(node.consequent, resolverName) ||
       hasNonEmptyResolverCall(node.alternate, resolverName);
   }
   case 'TryStatement': {
@@ -646,12 +648,24 @@ const hasNonEmptyResolverCall = (node, resolverName) => {
     );
   }
 
-  /*
+  case 'AssignmentExpression':
+  case 'BinaryExpression':
+  case 'LogicalExpression': {
+    return hasNonEmptyResolverCall(node.left, resolverName) ||
+      hasNonEmptyResolverCall(node.right, resolverName);
+  }
+
   // Comma
-  case 'SequenceExpression':
-  case 'ArrayExpression': case 'AssignmentExpression': case 'AssignmentPattern':
-  case 'AwaitExpression': case 'BinaryExpression': case 'ConditionalExpression':
-  case 'LogicalExpression': case 'MemberExpression': case 'OptionalMemberExpression':
+  case 'SequenceExpression': {
+    return node.expressions.some((subExpression) => {
+      return hasNonEmptyResolverCall(subExpression, resolverName);
+    });
+  }
+
+  /*
+  case 'ArrayExpression': case 'AssignmentPattern':
+  case 'AwaitExpression':
+  case 'MemberExpression': case 'OptionalMemberExpression':
   case 'VariableDeclaration':
   case 'OptionalCallExpression':
   case 'TaggedTemplateExpression':

test/rules/assertions/requireReturns.js

@@ -646,6 +646,28 @@ export default {
         },
       ],
     },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              if (resolve(true)) {
+                return;
+              }
+              return;
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
     {
       code: `
           /**
@@ -666,6 +688,26 @@ export default {
         },
       ],
     },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              true ? resolve(true) : null;
+              return;
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
     {
       code: `
           /**
@@ -920,6 +962,83 @@ export default {
           message: 'Missing JSDoc @returns declaration.',
         },
       ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              a || resolve(true);
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              (r = resolve(true));
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              a + (resolve(true));
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux () {
+            return new Promise((resolve, reject) => {
+              a, resolve(true);
+            });
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @returns declaration.',
+        },
+      ],
+      ignoreReadme: true,
     },
     {
       code: `