fix: noDupeKeys ignores ObjectTypeSpreadProperty #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new object type spread features in Flow cause the noDupeKeys rule to crash. Specifically,
.value
is accessed on theObjectTypeSpreadProperty
node, which doesn't have that field.The workaround is to use the Flow commenting syntax, like this:
/**
type Foo = {...Bar};
*/
I'd love to write tests (and had, in fact), but due to some combination of babylon, babel-eslint, and babel-cli, the object type spread syntax wasn't recognized and would fail tests (most immediately caused by babel-eslint). I tried bumping versions, but ended up going down a bit of a rabbit hole because other tests began failing. Seems like a general version bump refresh is in order.
Would appreciate any feedback, thanks!