-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance/Integration Tests introduction #133
Acceptance/Integration Tests introduction #133
Conversation
0a26263
to
1093930
Compare
One job is failing because of the race condition which should be fixed with my other PR. Once #132 has been merged and the job doesn't crash it should be ready to get merged! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the extraction of the server side stuff to server.go instead of making main even bigger. Nice job. :)
ddfaf74
to
abf69f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage ? 64.02%
=========================================
Files ? 25
Lines ? 2171
Branches ? 0
=========================================
Hits ? 1390
Misses ? 626
Partials ? 155
Continue to review full report at Codecov.
|
Acceptance/Integration tests are really important because they ensure that multiple components can still work together. In the past, we did this manually which had a negativ impact on our feature development time as well as it opened the door to introduce misterious side effects into Gaia.
This PR is the start of implementing an Acceptance/Integration test framework (we just use go tests) which also requires some refactoring.