Order the optional props

gaia-charge · Apr 17, 2024 · f683ae8 · f683ae8
1 parent faeb8d3
commit f683ae8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/longship/types.py b/longship/types.py
@@ -60,24 +60,30 @@ class ConnectivityStatusChangedData:
 
 
 @attr.s(auto_attribs=True)
-class SessionStartData:
+class BaseSessionData:
     chargepointid: str
     connectornumber: int
     transactionid: str
+
+@attr.s(auto_attribs=True)
+class SessionStartData(BaseSessionData):
     locationid: Optional[str] = attr.ib(default=None)
     evseid: Optional[str] = attr.ib(default=None)
 
 
 @attr.s(auto_attribs=True)
-class SessionUpdateData(SessionStartData):
+class SessionUpdateData(BaseSessionData):
     totalenergyinkwh: float
     totalduration: str
     totalcosts: float
+    locationid: Optional[str] = attr.ib(default=None)
+    evseid: Optional[str] = attr.ib(default=None)
 
 
 @attr.s(auto_attribs=True)
 class SessionStopData(SessionUpdateData):
-    pass
+    locationid: Optional[str] = attr.ib(default=None)
+    evseid: Optional[str] = attr.ib(default=None)
 
 
 @attr.s(auto_attribs=True)

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "longship"
-version = "2024.04.17"
+version = "2024.04.18"
 description = "A client library for accessing Longship API"
 
 authors = ["Wojtek Siudzinski <admin@suda.pl>"]