Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method-gridSearch.R #37

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Update method-gridSearch.R #37

merged 5 commits into from
Sep 1, 2022

Conversation

nickhsmith
Copy link
Contributor

avoids the corner case where a gene that modified for outlier injection is set to 0 resulting in a gene that has no reads across all samples.

if samples A, B, C have 0 counts and sample D has 100 counts for geneX. If geneX and sample D are modified to 0 to find outliers then in this new counts matrix geneX has no reads for all samples resulting in a failed checkCountRequirements check.

There are other ways to avoid this corner case, but seems simplest.

@nickhsmith
Copy link
Contributor Author

A more specific corner case handling. Injected 0 count outliers are allowed, as long as the other samples have at least 1 non-zero count for that gene.

@nickhsmith nickhsmith closed this Aug 26, 2022
@nickhsmith nickhsmith reopened this Aug 26, 2022
@nickhsmith nickhsmith closed this Sep 1, 2022
@nickhsmith nickhsmith reopened this Sep 1, 2022
@nickhsmith nickhsmith merged commit a458935 into gagneurlab:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant