Skip to content

Conversation

@johlju
Copy link
Collaborator

@johlju johlju commented Feb 17, 2025

Pull Request (PR) description

Fixed

  • Fixed issue with localization string testing with new version of the HQRM
    tests (module DscResource.Test).

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (b7f12ba) to head (b357d99).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #514   +/-   ##
===================================
- Coverage    81%    81%   -1%     
===================================
  Files        44     44           
  Lines      2338   2337    -1     
===================================
- Hits       1913   1912    -1     
  Misses      425    425           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju
Copy link
Collaborator Author

johlju commented Feb 17, 2025

The tests failing is most likely due to issue PoshCode/ModuleBuilder#135.

@johlju johlju added the on hold The issue or pull request has been put on hold by a maintainer. label Feb 17, 2025
@johlju
Copy link
Collaborator Author

johlju commented Feb 26, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 99707fb into gaelcolas:main Feb 28, 2025
14 checks passed
@johlju johlju deleted the fix/hqrm-test branch February 28, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold The issue or pull request has been put on hold by a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant