Alphabetically sort scrape result keys before writing to file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MillanWangGadget
commented
Nov 21, 2024
•
MillanWangGadget
commented
- The result of a scrape is non-deterministic which makes for some HUGE diffs with no functional changes
- To counteract this. the resulting JSON objects from a scrape will have their properties sorted alphabetically so the resulting diff will only account for functional differences
- Aside from the added lines in the scrape file, the net line difference in this PR should be zero
- Net neutral line change diff in json files
- 21 net new lines added in the scrape file
MillanWangGadget
force-pushed
the
mill/alphabeticallySortResultFromScrape
branch
from
18b11c7 to
5829ce9
Compare
MillanWangGadget
force-pushed
the
mill/alphabeticallySortResultFromScrape
branch
from
5829ce9 to
27b59d4
Compare
jasong689
reviewed
Nov 21, 2024
src/scrape.ts
Outdated
| @@ -68,6 +68,25 @@ const docsWebhooksPageForVersion = (version: string) => `https://shopify.dev/doc | |||
|
|
|||
| let warnings = 0; | |||
| let errors = 0; | |||
| const alphabeticallySortObjectByKeys = (obj: Object): Object => { | |||
There was a problem hiding this comment.
might be worth using safe-stable-stringify for this so we don't have to maintain this code
There was a problem hiding this comment.
Updated to use a lib to do the stable object key sorting, although I had to add a small lodash based utility to make sort string arrays
MillanWangGadget
force-pushed
the
mill/alphabeticallySortResultFromScrape
branch
from
27b59d4 to
7a7fe72
Compare
jasong689
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.