Fix margin/gap inconsistency between 5.0 and pre-5.0#415
Open
chenxiaolong wants to merge 1 commit intogabrielemariotti:masterfrom
Open
Fix margin/gap inconsistency between 5.0 and pre-5.0#415chenxiaolong wants to merge 1 commit intogabrielemariotti:masterfrom
chenxiaolong wants to merge 1 commit intogabrielemariotti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On pre-5.0,
CardView(appcompat v7) adds a margin to draw the shadow. cardslib also adds a6dpmargin to the cards inListViews andRecyclerViews, which results in large gaps between cards on pre-5.0 (see screenshots).CardViewhas acard_view:cardUseCompatPaddingattribute, which makes the 5.0 and pre-5.0 behavior match if set to true.With this commit,
ListViewandRecyclerViewnow behave identically on <=4.4 and 5.0. (Also fixes shadows on the sides of cards on 5.0).