Adding ability to change popup icon dynamically#320
Open
AkshayChordiya wants to merge 2 commits intogabrielemariotti:masterfrom
Open
Adding ability to change popup icon dynamically#320AkshayChordiya wants to merge 2 commits intogabrielemariotti:masterfrom
AkshayChordiya wants to merge 2 commits intogabrielemariotti:masterfrom
Conversation
Made popup drawable to NULL so that it can be dynamically updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gabrielemariotti
I needed ability to change popup drawable (icon) dynamically so I made it for my app & thought to share with everyone hence created a pull request.
There is small catch to this technique -
As I have set default popup drawable to NULL in style.xml, we need to always specify drawable from Java code as shown below.
Add this line in where you have used CardHeader