-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timezone argument to run and create #579
Conversation
@gabrieldemarmiesse did you want to have a look? Should be pretty uncontroversial :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we can merge this. I would be open to accept in the future a PR to accept datetime.timezone
as a valid argument for "tz". Of course str and None should always be accepted.
Thank you @LewisGaul for driving the code review!
de46667
into
gabrieldemarmiesse:master
tz
to the arguments forrun()
andcreate()
as per the arguments supported in podman:https://docs.podman.io/en/stable/markdown/podman-create.1.html#tz-timezone