Introduce ctr_client
fixture, add --ctr-exe
CLI arg
#522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #520 (comment):
This PR illustrates the improvement this offers - it makes it more explicit when testcases are using the
DockerClient
resource, which can be suitably set up in the fixture.Extensive information about pytest's fixtures and how they can/should be used is available at https://docs.pytest.org/en/latest/explanation/fixtures.html.
I've currently only updated a few test modules to use the fixture, but happy to do the same for the rest of the tests. This should be considered a nice precursor to parameterising on other runtimes, but for now this would at least allow manually running with podman.
Default, using docker (no change):
Using podman:
Using a container exe that's not available: