Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imagetools create command #419

Merged

Conversation

darpham
Copy link
Contributor

@darpham darpham commented Feb 19, 2023

Background

Changes

Open questions / follow-up work

  • Create unittest?

@gabrieldemarmiesse
Copy link
Owner

Hi! Thank you gor the pull request and the lint upgrade! Could yyou add some unit tests too? Thanks!

@darpham
Copy link
Contributor Author

darpham commented Feb 21, 2023

Hi! Thank you gor the pull request and the lint upgrade! Could yyou add some unit tests too? Thanks!

Hello, I'm really dumb and have never written tests before 🥲
I'm just really good at reading code and copy/pasting.

If you're willing to create tests, that'd be awesome.
Additionally, I'd be more than willing to hop on a zoom call to work together on this, so I can do it myself in the future. I love this repo, and would like to contribute more in the future as Docker continues to grow.

@gabrieldemarmiesse
Copy link
Owner

Apologies, i was quite busy those last few weeks, I skipped your message :(

No worries about it. While I won't really have the time to do a zoom call, I can write the test myself and you will be able to see what the test code should look like. Hopefully, that will help you understand a bit huw unit testing works.

I should have some time to make the unit tests Thursday :)

@gabrieldemarmiesse gabrieldemarmiesse enabled auto-merge (squash) March 30, 2023 13:43
@gabrieldemarmiesse gabrieldemarmiesse merged commit 3641099 into gabrieldemarmiesse:master Mar 30, 2023
@darpham darpham deleted the buildx-imagetools-create branch March 31, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants