-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Imagetools create command #419
Add Imagetools create command #419
Conversation
Hi! Thank you gor the pull request and the lint upgrade! Could yyou add some unit tests too? Thanks! |
Hello, I'm really dumb and have never written tests before 🥲 If you're willing to create tests, that'd be awesome. |
Apologies, i was quite busy those last few weeks, I skipped your message :( No worries about it. While I won't really have the time to do a zoom call, I can write the test myself and you will be able to see what the test code should look like. Hopefully, that will help you understand a bit huw unit testing works. I should have some time to make the unit tests Thursday :) |
Background
docker buildx imagetools create ...
Changes
create
method toImagetoolsCLI
https://gitlab.com/pycqa/flake8
github
url as it's more popular (gitlab requires login)isort
: Build from source (e.g. via pre-commit) is broken by new poetry version PyCQA/isort#2077isort
ambv
Open questions / follow-up work