-
Notifications
You must be signed in to change notification settings - Fork 259
Adds support for a second reference number #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update from original
Unfortunately this is a breaking change, as e.g. my current implementation will break. I'm using the 'setReferenceNumber' function to insert a ReferenceNumber object. Can we maybe find a workaround to introduce the same functionality, without making it breaking? E.g. what's the maximum amount of reference numbers? If not so many we can think of adding a setReferenceNumber2, etc. In any case there should be validation on the amount also, so if not too much this might be a nice workaround to get the same feature without breaking. |
True. The maximum number of reference numbers is two. I will adjust this as suggested. |
In principle this could be fixed by re-adding the original setReferenceNumber method. Is that fine? Or would you prefer a setReferenceNumber2 method? |
Two options I think:
My preference goes for the latter as it allows for proper type hinting, which is more strict in using the code. |
I adjusted the code, should be working now. |
Looks good. Could you (if possible) change also the CHANGELOG file to reflect this feature for release 0.7.1? Then I will merge it and bring out the new release. |
Great, thanks! The changelog is now up to date! |
Adds support for a second reference number
The UPS API allows to set two different reference numbers for a shipment. This functionality is added with this pull request.