Use mb_convert_encoding when encoding detected, else try utf8_encode #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I was getting an error sometimes:
It happened that the mb_detect_encoding call was returning FALSE in some cases, which in turn let mb_convert_encoding raise an error.
Small adjustment made to only use mb_convert_encoding in case there is a encoding known. The SimpleXmlElement object creation was not working in the same case when it was not converted to UTF-8, therefor the utf8_encode call is introduced. I'm only performing both in the situation mb_convert_encoding is available, as we only did transform things when this function exists. I can't test it very well what would happen in the case it ain't available.
@gabrielbull I think this is safe to do (and works better in my set-up), but could you also have a look?