-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Enable defining custom namespace for spdlog #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hel-ableton
wants to merge
5
commits into
gabime:v2.x
Choose a base branch
from
hel-ableton:hel-ns-macros-pr-v2.x
base: v2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+189
−153
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b4747e8
Enable defining custom namespace for spdlog
hel-ableton 1d52715
fixup! Enable defining custom namespace for spdlog
hel-ableton ca6be4e
Remove redundant spdlog:: qualification inside namespace blocks
hel-ableton 4072679
fixup! Enable defining custom namespace for spdlog
hel-ableton 6aeba71
fixup! fixup! Enable defining custom namespace for spdlog
hel-ableton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ | |
|
|
||
| #include <filesystem> | ||
|
|
||
| #include "./namespace.h" | ||
|
|
||
| #ifdef _WIN32 | ||
| // In windows, add L prefix for filename literals (e.g. L"filename.txt") | ||
| #define SPDLOG_FILENAME_T_INNER(s) L##s | ||
|
|
@@ -13,6 +15,6 @@ | |
| #define SPDLOG_FILENAME_T(s) s | ||
| #endif | ||
|
|
||
| namespace spdlog { | ||
| SPDLOG_NAMESPACE_BEGIN | ||
| using filename_t = std::filesystem::path; | ||
| } // namespace spdlog | ||
| SPDLOG_NAMESPACE_END | ||
|
Comment on lines
16
to
+20
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See 1d52715 |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,9 @@ | |
|
|
||
| #pragma once | ||
|
|
||
| namespace spdlog { | ||
| #include "./namespace.h" | ||
|
|
||
| SPDLOG_NAMESPACE_BEGIN | ||
| class logger; | ||
|
Comment on lines
4
to
9
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See 1d52715 |
||
| class formatter; | ||
| enum class level; | ||
|
|
@@ -12,4 +14,4 @@ namespace sinks { | |
| class sink; | ||
| } | ||
|
|
||
| } // namespace spdlog | ||
| SPDLOG_NAMESPACE_END | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright(c) 2015-present, Gabi Melman & spdlog contributors. | ||
| // Distributed under the MIT License (http://opensource.org/licenses/MIT) | ||
|
|
||
| #pragma once | ||
|
|
||
| // SPDLOG_NS__ is the outermost namespace token used to qualify spdlog names | ||
| // in contexts outside a SPDLOG_NAMESPACE_BEGIN block (e.g. logging macros). | ||
| // Override it to rename the outer namespace. | ||
| #ifndef SPDLOG_NS__ | ||
| #define SPDLOG_NS__ spdlog | ||
| #endif | ||
| // SPDLOG_NAMESPACE_BEGIN / SPDLOG_NAMESPACE_END delimit every spdlog | ||
| // declaration, defaulting to "namespace SPDLOG_NS__ { ... }". | ||
| // Override both to use a more complex namespace expression, e.g. to wrap | ||
| // symbols in an inline sub-namespace (keeps "spdlog::" accessible): | ||
| // #define SPDLOG_NAMESPACE_BEGIN namespace spdlog::inline my_copy { | ||
| // #define SPDLOG_NAMESPACE_END } | ||
| #ifndef SPDLOG_NAMESPACE_BEGIN | ||
| #define SPDLOG_NAMESPACE_BEGIN namespace SPDLOG_NS__ { | ||
| #endif | ||
| #ifndef SPDLOG_NAMESPACE_END | ||
| #define SPDLOG_NAMESPACE_END } | ||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 1d52715