Fix #3525: Make level name matching case-insensitive#3535
Merged
gabime merged 1 commit intogabime:v1.xfrom Feb 9, 2026
Merged
Conversation
Modified from_str() to perform case-insensitive comparison for all level names. This allows environment variables and SPDLOG_LEVEL_NAMES to use uppercase or mixed case level names (e.g., DEBUG, INFO, Warning) while maintaining full backward compatibility with existing lowercase names.
Contributor
|
Thank you for contribution but duplicate this PR: #3531 |
|
Hmm. I didn't realized it. Thanks for checking it |
gabime
requested changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where uppercase level names in environment variables weren't recognized. The from_str() function now does case-insensitive matching, so SPDLOG_LEVEL="DEBUG" works just like "debug". All existing tests pass plus new tests verify uppercase and mixed-case level names work correctly.