Getting compile-error in logger_impl.h#L255

[hestad]

spdlog/include/spdlog/details/logger_impl.h

Line 255 in b1be7b9

}

There is an extra right curly braces. (at least for clang 5)

How come your build-server flagged this as green?

[gabime]

Because the clang tests were removed a while ago :(

[gabime]

Fixed in 88fe218

Please verify it solves your problem

[hestad]

I would guess you never call #define SPDLOG_WCHAR_TO_UTF8_SUPPORT in your tests?

[hestad]

Yes, that fixes it for me.

[hestad]

Btw, since I have you here :) when do you plan to release spdlog next time?

[gabime]

Very soon. Hopefully in the next few days. Why?

[hestad]

I'm waiting for two of the wstring-fixes, but also a fmt-fix related to wstring. (ref:
fmtlib/fmt#606 (comment) )

I have just copied the sources for now, but ideally we would get spdlog + fmt via conan.

[gabime]

Please note that spdlog bundles only official fmt versions, not necessarily with the latest fixes from the fmt repo..

[hestad]

Yeah, I guessed as much, but I also agree. I had a tiny dream that they could be co-released :)

[gabime]

Do you know when fmt plan to release? that can be arranged

[hestad]

Seems like they accepted to do a release the next few days: fmtlib/fmt#621 (comment)

[gabime]

Oh thats good. I will wait..