Disallow strings as input for wstring templates #606
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent mixing character encodings by accident, by disallowing using strings as input for wstring templates.
The change will cause the following to be a compile error:
Use case: Using a wstring as a template with an UTF-8 string will mix UTF-32/UTF-16 and UTF-8 in the resulting string. When you try to convert the string to UTF-8,
to_bytes
will throw an exception.