chore: Ensure all errors are handled

gabe565 · May 4, 2024 · d101a86 · d101a86
1 parent e4b7f8c
commit d101a86
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/cmd/cmd.go b/cmd/cmd.go
@@ -53,8 +53,8 @@ func run(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	_, _ = io.WriteString(cmd.OutOrStdout(), conf.String())
-	return nil
+	_, err = io.WriteString(cmd.OutOrStdout(), conf.String())
+	return err
 }
 
 func buildVersion(version, commit string) string {

diff --git a/internal/config/flags.go b/internal/config/flags.go
@@ -10,14 +10,18 @@ const (
 
 func RegisterFlags(cmd *cobra.Command) {
 	cmd.Flags().String(ConfigFlag, "", `Config file (default ".changelog-generator.yaml")`)
-	_ = cmd.RegisterFlagCompletionFunc(ConfigFlag, func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
+	if err := cmd.RegisterFlagCompletionFunc(ConfigFlag, func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
 		return []string{"yaml"}, cobra.ShellCompDirectiveFilterFileExt
-	})
+	}); err != nil {
+		panic(err)
+	}
 
 	cmd.Flags().String(RepoFlag, ".", `Path to the git repo root. Parent directories will be walked until .git is found.`)
-	_ = cmd.RegisterFlagCompletionFunc(RepoFlag, func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
+	if err := cmd.RegisterFlagCompletionFunc(RepoFlag, func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
 		return []string{}, cobra.ShellCompDirectiveFilterDirs
-	})
+	}); err != nil {
+		panic(err)
+	}
 
 	cmd.Flags().String(CompletionFlag, "", "Output command-line completion code for the specified shell. Can be 'bash', 'zsh', 'fish', or 'powershell'.")
 	if err := cmd.RegisterFlagCompletionFunc(CompletionFlag, func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {