CMakeLists: add BUILD_{SHARED,STATIC}_LIBS options #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BUILD_SHARED_LIBS and BUILD_STATIC_LIBS options to allow the user to enable/disable building of shared and static library This is especially useful when cross-compiling as some toolchains are not always able to build a shared or a static library Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
I might ask you to support this feature here some users encounter issues with it. Thanks for contributing. |
|
I'll be pleased to support this feature however I have a small question: why does the glm CMakeLists.txt has provision to build static and shared libraries if it's a header-only library? |
I still doesn't know why, but I suggest:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BUILD_SHARED_LIBS and BUILD_STATIC_LIBS options to allow the user
to enable/disable building of shared and static library
This is especially useful when cross-compiling as some toolchains are
not always able to build a shared or a static library
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com