Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressed VC warnings with /permissive- #775

Closed
wants to merge 1 commit into from
Closed

Suppressed VC warnings with /permissive- #775

wants to merge 1 commit into from

Conversation

kiwixz
Copy link

@kiwixz kiwixz commented Jun 2, 2018

So we can keep warning-free headers, instead of C4201.

@Groovounet Groovounet self-assigned this Jul 15, 2018
@Groovounet
Copy link
Member

GLM should not generate warnings inconsistently from the compilers settings.

For example, if the project use /W4 warnings but allows language extensions (not using /Za), then GLM should not generate warnings. This should include /permissive-.

Thanks,
Christophe

@Groovounet Groovounet closed this Jul 15, 2018
@past-due
Copy link

@Groovounet: Ah, I see, some changes since the last release related to this. Thanks!

@kiwixz
Copy link
Author

kiwixz commented Jul 28, 2018

@Groovounet I feel like those warnings still should be suppressed because GLM will work without the Microsoft extensions (while the compiler is warning us it may not).
It is especially bothering because one cannot use /Za if using windows headers or libraries depending on windows headers 😢

@Groovounet
Copy link
Member

When you disable MS extensions; these warnings will be gone.
If you use MS extensions, then I would recommand to use /W3, the level were MS extensions are not reported.

Thanks,
Christophe

Groovounet added a commit that referenced this pull request Sep 18, 2018
…guage extensions but using W4 or Wpedantic warnings #814 #775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants