Fixed incorrect assertion for min and max #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from master
Zuzu-Typ
added a commit
to Zuzu-Typ/PyGLM
that referenced
this pull request
Apr 23, 2020
Fixed #66 Temporary workaround / fix for g-truc/glm#1009
Zuzu-Typ
added a commit
to Zuzu-Typ/PyGLM
that referenced
this pull request
Apr 23, 2020
* Updated type checker format types * Updated README * Added norm, fixed div/0 + Added the norm extension ( #63 ) + Fixed #65 for types ~ Moved silence to warnings.h ~ Fixed a few minor issues * Added decompose extension #68 is done * Fixed clamp, min and max for int types Fixed #66 Temporary workaround / fix for g-truc/glm#1009 * Improved setattr for vec types Should fix #67 * Updated tests
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vector_common, the min and max functions exclaim to
even though they only accept floating-point inputs.
This pr should fix that.
The min and max functions in func_common are fine though and have correct assertions (: