Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash.hpp uses tquat not qua #919

Closed
petersteneteg opened this issue Jun 26, 2019 · 0 comments
Closed

Hash.hpp uses tquat not qua #919

petersteneteg opened this issue Jun 26, 2019 · 0 comments

Comments

@petersteneteg
Copy link

hash.hpp / hash.inl uses the old tquat not qua

glm/glm/gtx/hash.hpp

Lines 75 to 85 in f920ffa

template<typename T, glm::qualifier Q>
struct hash<glm::tquat<T,Q>>
{
GLM_FUNC_DECL size_t operator()(glm::tquat<T, Q> const& q) const;
};
template<typename T, glm::qualifier Q>
struct hash<glm::tdualquat<T,Q> >
{
GLM_FUNC_DECL size_t operator()(glm::tdualquat<T,Q> const& q) const;
};

this makes code without template aliases to fail since then tquat is not defined.

petersteneteg added a commit to inviwo/glm that referenced this issue Jun 26, 2019
Groovounet added a commit that referenced this issue Jul 9, 2019
Hash hashes qua instead of tquat closes #919 #920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant