Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ffi call port argument #305

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

valeth
Copy link
Contributor

@valeth valeth commented Jan 23, 2022

Fixes #304

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 24, 2022

Thanks for the bugfix!

Could you please follow https://github.com/fzyzcjy/flutter_rust_bridge/blob/master/CONTRIBUTING.md#appendix-sample-commands-to-run-code-generator

  • Appendix: Sample commands to run code generator
  • Appenfix: Format and lint everything

and commit the code change. otherwise CI will fail

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 24, 2022

@all-contributors please add @valeth for code

@allcontributors
Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @valeth! 🎉

@fzyzcjy fzyzcjy merged commit f76e471 into fzyzcjy:master Jan 24, 2022
@welcome
Copy link

welcome bot commented Jan 24, 2022

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 24, 2022

🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Potential name collision with port argument
2 participants