Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clone+Debug+Default for RustAutoOpaque ; Allow RustAutoOpaque inner value to be non-Clone #2293

Merged
merged 30 commits into from
Sep 12, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Sep 12, 2024

Changes

Close #2272

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (9ab7435) to head (cec70b7).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
frb_rust/src/rust_auto_opaque/inner.rs 0.00% 2 Missing ⚠️
frb_rust/src/rust_auto_opaque/utils.rs 60.00% 2 Missing ⚠️
frb_rust/src/rust_opaque/utils.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2293      +/-   ##
==========================================
- Coverage   98.97%   98.94%   -0.03%     
==========================================
  Files         490      491       +1     
  Lines       20276    20284       +8     
==========================================
+ Hits        20069    20071       +2     
- Misses        207      213       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 5608d3d into master Sep 12, 2024
134 of 137 checks passed
@fzyzcjy fzyzcjy deleted the feat/2272 branch September 12, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement trait deriving for RustAutoOpaque (Clone, Debug, PartialEq, Eq)
1 participant