-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mock mode #2248
feat: mock mode #2248
Conversation
Hi! Thanks for opening this pull request! 😄 |
a14791c
to
66f47e5
Compare
Good job! Some nits
|
a3e2bf5
to
6550c4e
Compare
Thanks for the quick response! Actually, I had it like Edit: I've run |
You are welcome!
Looks pretty reasonable.
Looks like need to edit https://github.com/fzyzcjy/flutter_rust_bridge/tree/master/frb_codegen/assets/integration_template/shared (e.g. copy-paste/modify things according to the CI hint) which is the template |
Thanks! I am currently not at home so feel free to add it. Otherwise, I will add it tomorrow |
@all-contributors please add @Tienisto for code |
I've put up a pull request to add @Tienisto! 🎉 |
Hi! Congrats on merging your first pull request! 🎉 |
@Tienisto Looks like codecov is unhappy (see below; not sure why codecov does not appear in this PR...). Maybe we can add a few lines in https://github.com/fzyzcjy/flutter_rust_bridge/blob/master/frb_example/pure_dart/test/mockability_test.dart to test this code path. |
Changes
Fixes #2247.
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.