Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geneartion of async functions when default_dart_async: false ; Update frb_example/integrate_third_party #2190

Merged
merged 9 commits into from
Jul 7, 2024

Conversation

Larpoux
Copy link
Contributor

@Larpoux Larpoux commented Jul 5, 2024

Changes

Fixes #2178.
Fixes #2167.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@Larpoux
Copy link
Contributor Author

Larpoux commented Jul 6, 2024

Please, is there someone to explain me why this check was unsuccessful ?

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2024

Click the "Details" button and we can see error logs. Looks like the codegen is not run. Thus try

cargo run --manifest-path /path/to/flutter_rust_bridge/frb_codegen/Cargo.toml -- generate

on frb_example/integrate_third_party folder

@Larpoux
Copy link
Contributor Author

Larpoux commented Jul 6, 2024

I would like to add a simple check that [#2178] is correctly fixed. How do you suggest doing that ?

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2024

Since that issue happens in realworld (web audio api), the simplest way may be: Just copycode into frb_example/integrate_third_party, including the code that causes the problem (iirc it is default_dart_async: false in flutter_rust_bridge.yaml). Then, since CI auto execute codegen tests etc on that example, we automatically ensure it works.

@fzyzcjy fzyzcjy changed the title Fix Issue [#2178] and Issue [#2167] Fix geneartion of async functions when default_dart_async: false ; Update frb_example/integrate_third_party Jul 7, 2024
@fzyzcjy fzyzcjy merged commit 4fc9684 into fzyzcjy:master Jul 7, 2024
135 checks passed
Copy link

welcome bot commented Jul 7, 2024

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 7, 2024

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants