Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more attributes ; Add examples ; Fix generated use statement pointing to self ; Fix linter warning avoid_return_types_on_setters ; Reduce number of generated files #2140

Merged
merged 99 commits into from
Jun 22, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 22, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support more attributes ; Fix generated use statement pointing to self ; Fix linter warning avoid_return_types_on_setters Support more attributes ; Add examples ; Fix generated use statement pointing to self ; Fix linter warning avoid_return_types_on_setters Jun 22, 2024
@fzyzcjy fzyzcjy changed the title Support more attributes ; Add examples ; Fix generated use statement pointing to self ; Fix linter warning avoid_return_types_on_setters Support more attributes ; Add examples ; Fix generated use statement pointing to self ; Fix linter warning avoid_return_types_on_setters ; Reduce number of generated files Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 99.32660% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.10%. Comparing base (b68eb1d) to head (1537b49).

Files Patch % Lines
...gen/generator/wire/dart/spec_generator/misc/mod.rs 92.85% 1 Missing ⚠️
...rator/wire/rust/spec_generator/misc/ty/delegate.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   99.12%   99.10%   -0.02%     
==========================================
  Files         485      486       +1     
  Lines       19814    20042     +228     
==========================================
+ Hits        19640    19862     +222     
- Misses        174      180       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 22, 2024 23:53
@fzyzcjy fzyzcjy merged commit 5a914de into master Jun 22, 2024
132 of 134 checks passed
@fzyzcjy fzyzcjy deleted the feat/12392 branch June 22, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant