-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more attributes ; Add examples ; Fix generated use
statement pointing to self ; Fix linter warning avoid_return_types_on_setters ; Reduce number of generated files
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzyzcjy
changed the title
Support more attributes ; Fix generated
Support more attributes ; Add examples ; Fix generated Jun 22, 2024
use
statement pointing to self ; Fix linter warning avoid_return_types_on_settersuse
statement pointing to self ; Fix linter warning avoid_return_types_on_setters
fzyzcjy
changed the title
Support more attributes ; Add examples ; Fix generated
Support more attributes ; Add examples ; Fix generated Jun 22, 2024
use
statement pointing to self ; Fix linter warning avoid_return_types_on_settersuse
statement pointing to self ; Fix linter warning avoid_return_types_on_setters ; Reduce number of generated files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 99.12% 99.10% -0.02%
==========================================
Files 485 486 +1
Lines 19814 20042 +228
==========================================
+ Hits 19640 19862 +222
- Misses 174 180 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please list issues fixed by this PR here, using format "Fixes #the-issue-number".
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.