Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use dart.library.js_interop rather than dart.library.html #2113

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

aran
Copy link
Contributor

@aran aran commented Jun 18, 2024

Per Dart guidelines using dart.library.html is deprecated in favor of dart.library.js_interop. This is a find-replace fix.

https://dart.dev/interop/js-interop/package-web

Changes

Fixes #2112

Checklist

  • [X ] An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Per Dart guidelines using dart.library.html is deprecated in favor of
dart.library.js_interop. This is a find-replace fix.

https://dart.dev/interop/js-interop/package-web
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (97f4df4) to head (fcabafd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2113   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         485      485           
  Lines       19597    19597           
=======================================
  Hits        19286    19286           
  Misses        311      311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 19, 2024

Good job!

I will merge and resolve the CI failures later, because the lint and integrate-third-party is being handled by another PR, and I temporarily allow CI to fail on master on such unimportant things to speed up development.

@fzyzcjy fzyzcjy merged commit 39c1f80 into fzyzcjy:master Jun 19, 2024
104 of 106 checks passed
@aran aran deleted the js_interop branch June 19, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dart.library.js_interop not dart.library.html
2 participants