Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix for automatically generated get/set methods of #[frb(opaque)] types to avoid conflicting with existing methods #2090

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

dbsxdbsx
Copy link
Contributor

@dbsxdbsx dbsxdbsx commented Jun 15, 2024

Changes

Add fixed prefix auto_accessor for auto-generated reflection methods signatures, which is used as reflections for fields within Rust types tagged with #[frb(opaque)].
Related issue: #2079

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@dbsxdbsx dbsxdbsx changed the title add prefix for get/set methods of #[frb(opaque)] types Add fixed prefix for get/set methods of #[frb(opaque)] types Jun 15, 2024
Copy link
Owner

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Will merge after green CI

@fzyzcjy fzyzcjy changed the title Add fixed prefix for get/set methods of #[frb(opaque)] types Add prefix for automatically generated get/set methods of #[frb(opaque)] types to avoid conflicting with existing methods Jun 15, 2024
@fzyzcjy fzyzcjy merged commit 96059bc into fzyzcjy:master Jun 15, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants