Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #[frb(proxy)] (part 1) #2050

Merged
merged 143 commits into from
Jun 9, 2024
Merged

Support #[frb(proxy)] (part 1) #2050

merged 143 commits into from
Jun 9, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 8, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 96.85864% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (5f2065e) to head (7bcc32f).

Files Patch % Lines
.../codegen/parser/mir/parser/function/real/output.rs 89.28% 3 Missing ⚠️
frb_dart/lib/src/misc/simple_disposable.dart 0.00% 3 Missing ⚠️
.../generator/api_dart/spec_generator/class/method.rs 95.55% 2 Missing ⚠️
...st/spec_generator/codec/cst/decoder/ty/delegate.rs 0.00% 2 Missing ⚠️
...rt/spec_generator/codec/cst/encoder/ty/delegate.rs 0.00% 1 Missing ⚠️
...odegen/parser/mir/parser/function/real/argument.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   96.95%   95.26%   -1.70%     
==========================================
  Files         460      458       -2     
  Lines       18093    16899    -1194     
==========================================
- Hits        17542    16098    -1444     
- Misses        551      801     +250     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy changed the title Support #[frb(proxy)] Support #[frb(proxy)] (part 1) Jun 9, 2024
@fzyzcjy fzyzcjy marked this pull request as ready for review June 9, 2024 01:15
@fzyzcjy fzyzcjy merged commit 1dcc30b into master Jun 9, 2024
80 of 106 checks passed
@fzyzcjy fzyzcjy deleted the feat/12184 branch June 9, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant