Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI artifacts for headless mode #260

Closed
wants to merge 1 commit into from

Conversation

ethancadoo
Copy link
Contributor

No description provided.


- name: Dart Compile
run: |
dart compile exe ./bin/convenient_test_manager_dart.dart -o manager_headless
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can dart compile exe on ubuntu, mac, and windows (using the runs-on param). Then we can native executable for all three platforms :)


- uses: actions/upload-artifact@v3
with:
name: manager_linux-mac_headless_cli
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is only useable on linux, not on mac. This is probably because dart compile exe does not support cross compilation, and mac has different executable format than linux.

So maybe we should rename as sth like manager_headless_linux

e.g. the file, if executed on a mac, gives:

/Users/.../Downloads/manager_headless          
zsh: exec format error: /Users/.../Downloads/manager_headless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a mac to test but I was going based off this comment: dart-lang/sdk#28617 (comment)

That user claims, ubuntu and mac should be cross compatible. I added in the kernel file so there is at least something that is cross compatible to all platforms. :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Unfortunately it does not work according to my experiment.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Aug 19, 2022

Good job! Just some minor thoughts

@stale
Copy link

stale bot commented Oct 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 18, 2022
@stale stale bot closed this Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants